Fix System.Net.Http.Functional.Tests.*.NoCallback_RevokedCertificate_RevocationChecking_Fails #119297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds back a missing line of code that was inadvertently omitted in a previous PR (#118456). The change specifically sets the CheckCertificateRevocationList property to true in a test that validates revocation checking behavior.
Key Changes
- Adds the missing
CheckCertificateRevocationList = trueassignment to ensure the test properly validates certificate revocation checking
rzikm
changed the title
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Sep 3, 2025
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Will this be backported to 10.0 branch?
Member
Author
It should |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17434977803 |
4 tasks
filipnavara
pushed a commit
to filipnavara/runtime
that referenced
this pull request
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back change that was missed in #118456.